Smoking in moderation is not a sin at all (CCC 2290).
I have two concerns on that statement.
First concern: But what about CCC 2291?
Respect for health
2288 Life and physical health are precious gifts entrusted to us by God. We must take reasonable care of them, taking into account the needs of others and the common good.
Concern for the health of its citizens requires that society help in the attainment of living-conditions that allow them to grow and reach maturity: food and clothing, housing, health care, basic education, employment, and social assistance.
2289 If morality requires respect for the life of the body, it does not make it an absolute value. It rejects a neo-pagan notion that tends to promote the cult of the body, to sacrifice everything for it's sake, to idolize physical perfection and success at sports. By its selective preference of the strong over the weak, such a conception can lead to the perversion of human relationships.
2290 The virtue of temperance disposes us to avoid every kind of excess: the abuse of food, alcohol, tobacco, or medicine. Those incur grave guilt who, by drunkenness or a love of speed, endanger their own and others' safety on the road, at sea, or in the air.
2291 The use of drugs inflicts very grave damage on human health and life. Their use, except on strictly therapeutic grounds, is a grave offense. Clandestine production of and trafficking in drugs are scandalous practices. They constitute direct co-operation in evil, since they encourage people to practices gravely contrary to the moral law.
Smoking involves drugs such as marijuana or nicotine right? So how can smoking be permitted under non-medical circumstances?
I operate under CCC 2291 not prohibiting drinking coffee in moderation as caffeine, while it is a drug, is GRAS and CCC 2291 instead referring to drugs that have or should have government warnings or prescriptions from doctors.
Second concern: The Catholic Church is against masturbation, but it seems to me that smoking is worse than masturbation.